Fix thumbnail alignment in PDF extension#1541
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
demiankatz
approved these changes
Sep 26, 2025
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @Saira-A, this looks much better to me.
I won't merge this right away in case @LanieOkorodudu or others want to give it a closer look... but please feel free to merge once you're satisfied that you've received enough feedback!
Contributor
|
Thanks @Saira-A, this looks much better now. @demiankatz, happy for you to go ahead and merge the fix. |
Contributor
Author
|
Thanks @LanieOkorodudu @demiankatz! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #1529 by adding a grid for one column thumbnails.
I also adjusted the thumbnail focus styling as previously when a PDF thumbnail or label was clicked on they were both outlined with a separating line between them, so now only the thumbnail is outlined but tabbing highlights them both as one unit which is how it works for OSD