Architecture#1462
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
@jamesmisson, I haven't had a chance to take a close look at this yet, but I wonder if the best course of action would be to merge this work into the architecture branch, and then open a new PR to merge the architecture branch into dev -- that way, we can see all of the work in progress in a format where we can discuss and refine it. If you think this is a good idea, let me know and I'll be happy to approve and merge this so we can move forward with the next step. |
Contributor
Author
|
Thanks @demiankatz , I think that's a good idea. I think @LlGC-jop will be back soon so we can ask him what he thinks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here are some brief descriptions of the dialogues. Some of these aren't functional, or partially functional, but I've stuck to explaining what they should do here.