ESLint install and configure#1426
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
requested changes
May 19, 2025
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @LlGC-jop! A couple things:
1.) Looks like there's a conflict that needs to be resolved here (probably caused by my merge of the recent Webpack update).
2.) Should we remove tslint while adding eslint, to make it clear we're replacing one with the other?
3.) It's not clear to me exactly where in the workflow tslint was running previously, or where eslint will run now. Do we need to make changes to package.json scripts and/or GitHub actions to actually leverage this tool?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ESLint packages, config file, and vscode workspace settings.