Skip to content

Update vscode settings to never mess with imports - resolves #1396#1424

Merged
demiankatz merged 2 commits into
UniversalViewer:devfrom
LlGC-jop:auto-formatting
May 19, 2025
Merged

Update vscode settings to never mess with imports - resolves #1396#1424
demiankatz merged 2 commits into
UniversalViewer:devfrom
LlGC-jop:auto-formatting

Conversation

@LlGC-jop

Copy link
Copy Markdown
Contributor

Resolves #1396

Will stop VSCode from changing imports when saving files.

@vercel

vercel Bot commented May 19, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 19, 2025 1:52pm

demiankatz
demiankatz previously approved these changes May 19, 2025

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted elsewhere, this looks good to me but I'll wait until the stand-up to merge it. It duplicates #1422, so I closed that one and kept this one since this version keeps the settings in alphabetical order and references the related issue, whereas the earlier PR did not.

@demiankatz demiankatz merged commit 3e8b0f9 into UniversalViewer:dev May 19, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: COMPLETED

Development

Successfully merging this pull request may close these issues.

Agree on using import optimisation in future commits - VSCode's way seems to make sense to me

2 participants