Make sure attribution box stays closed; fixes #1327.#1328
Merged
demiankatz merged 3 commits intoMar 10, 2025
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
3 tasks
jamesmisson
approved these changes
Mar 7, 2025
jamesmisson
left a comment
Contributor
There was a problem hiding this comment.
Code checked and deployment tested, looks good and is working as expected.
Contributor
|
@demiankatz This fix looks good, I have tested in mobile view and it work as expected. Thanks for your time looking into this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a flag to track when the user has explicitly closed the attribution box, and keeps it closed until the next manifest is loaded. It seems to work for me as I would expect... however, I'm not sure why the code worked correctly in the past. My git bisect investigation in #1327 didn't turn up any clues that made sense to me, and this solution is not a direct response to those findings.