Bump zustand from 4.1.5 to 5.0.3#1270
Conversation
Bumps [zustand](https://github.com/pmndrs/zustand) from 4.1.5 to 5.0.3. - [Release notes](https://github.com/pmndrs/zustand/releases) - [Commits](pmndrs/zustand@v4.1.5...v5.0.3) --- updated-dependencies: - dependency-name: zustand dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
left a comment
There was a problem hiding this comment.
This is breaking the build; we'll have to figure out why and make updates before we can merge.
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @crhallberg! This seems to be working, but see below for one possible adjustment (though I trust your judgment above my own in this instance).
|
|
||
| dispose(): void { | ||
| this.store?.destroy(); | ||
| // pass |
There was a problem hiding this comment.
This discussion thread suggests that maybe this.store?.setState(null); would be a worthwhile replacement for the deprecated destroy call to help ensure appropriate garbage collection. What do you think?
There was a problem hiding this comment.
Thanks! I searched around, but mostly to see if .destroy() was every a zustand option.
There was a problem hiding this comment.
Hmm, looks like it doesn't actually work: Argument of type 'null' is not assignable to parameter of type 'ExtensionState | Partial<ExtensionState> | ((state: ExtensionState) => ExtensionState | Partial<ExtensionState>)
There was a problem hiding this comment.
Maybe we need to set the state to an explicitly created empty state, instead of null.
demiankatz
left a comment
There was a problem hiding this comment.
I like it -- thanks, @crhallberg!
Bumps zustand from 4.1.5 to 5.0.3.
Release notes
Sourced from zustand's releases.
... (truncated)
Commits
3f9127f5.0.36eff6e7chore(deps): update dev dependencies (#2944)4378abefix(build): alias entries in rollup config (#2942)d2ac820feat(types): Make ExtractState public (#2935)929b547docs(create-store.md): fix incorrect usage ofcreatefunction in example (#...efaf416docs(create.md): fix state selector syntax in troubleshooting example (#2938)07b32d6change prettier to fix:format (#2936)6759fcbchore(.github/workflows): change 'node-version' to 'lts/*' in 'actions/setup-...2e6d881chore(eslint): change 'dist' area in 'ignores', sort rules (#2924)55a7d0achore(eslint): migrate to flat config and simplify (#2912)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)