Skip to content

Replaced divs with label class with label element (fixes #1103)#1152

Merged
demiankatz merged 1 commit into
UniversalViewer:devfrom
msimpsonBL:fix-issue-1103
Oct 21, 2024
Merged

Replaced divs with label class with label element (fixes #1103)#1152
demiankatz merged 1 commit into
UniversalViewer:devfrom
msimpsonBL:fix-issue-1103

Conversation

@msimpsonBL

Copy link
Copy Markdown
Contributor

Fixes #1103

Only remaining instance was the page position label in the footer:
image

@vercel

vercel Bot commented Oct 21, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
universalviewer βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 21, 2024 1:48pm

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @msimpsonBL, looks good to me!

@LanieOkorodudu and others, any concerns before we merge this?

@LanieOkorodudu LanieOkorodudu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demiankatz . I just tested it and looks good on my end. Thanks @msimpsonBL

@demiankatz demiankatz merged commit b74120a into UniversalViewer:dev Oct 21, 2024
@msimpsonBL msimpsonBL deleted the fix-issue-1103 branch October 21, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Community Sprint COMPLETED

Development

Successfully merging this pull request may close these issues.

3 participants