The latest updates on your projects. Learn more about Vercel for Git ↗︎

(Bottom line: it wouldn't hurt to get somebody else's eyes on this, especially if they know how to trigger both 3-D viewers... but I think it's safe to merge regardless).

Thanks, @Saira-A, this looks good to me. I tested every extension that I knew how to, and confirmed that the fix works everywhere. (The only thing I wasn't 100% sure about was which extension gets used for 3-D models -- it's either uv-aleph-extension or uv-model-viewer-extension depending on the file format; whichever one of those I tested with the astonaut model worked fine, but I'm not sure how to trigger the other one... in any case, since the pattern is consistent everywhere, I'm reasonably confident it works correctly).

Me too - I'm pretty sure the astronaut is model-viewer but couldn't find an aleph manifest

Me too - I'm pretty sure the astronaut is model-viewer but couldn't find an aleph manifest

It looks like the Aleph extension is used for DICOM images; see:

I wonder if perhaps @edsilv can point us to a DICOM example manifest that we can incorporate into the standard example list....

@demiankatz @Saira-A, I've tested the Vercel app and confirmed that the fix works well across all extensions. The addition of the title attribute to the embed iframe enhances accessibility, and everything is functioning as expected.

Thanks, @Saira-A and @LanieOkorodudu! I'm going to go ahead and merge this; we can double-check the aleph case if we get an example, but I'm reasonably confident that it will be fine in the meantime. :-)