Add accessible name to imageButton.searchButton (fixes #1100)#1128
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
demiankatz
approved these changes
Oct 16, 2024
demiankatz
left a comment
Contributor
There was a problem hiding this comment.
Thanks, @LlGC-jop, looks reasonable to me from a code perspective; wondering if @LanieOkorodudu or others can do a hands-on test to confirm the desired functionality.
Contributor
There was a problem hiding this comment.
@demiankatz, I can now see the appropriate label when hovering over the search button, ensuring better accessibility and user experience. Great work on fixing this @LlGC-jop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1100
Sets aria-label and title on the search button with already-present searchWithin text.
en - Search within this item:
cy - Chwilio tu fewn i: