Skip to content

Improve ambiguous "more info" label (fixes #1074)#1127

Merged
demiankatz merged 4 commits into
UniversalViewer:devfrom
Geoffsc:1074-ambiguous-link-text
Oct 18, 2024
Merged

Improve ambiguous "more info" label (fixes #1074)#1127
demiankatz merged 4 commits into
UniversalViewer:devfrom
Geoffsc:1074-ambiguous-link-text

Conversation

@Geoffsc

@Geoffsc Geoffsc commented Oct 16, 2024

Copy link
Copy Markdown
Contributor

Fix for #1074

@vercel

vercel Bot commented Oct 16, 2024

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 18, 2024 3:23pm

@Geoffsc

Geoffsc commented Oct 16, 2024

Copy link
Copy Markdown
Contributor Author

@jamesmisson @demiankatz

@demiankatz

Copy link
Copy Markdown
Contributor

Thanks, @Geoffsc, this makes sense to me -- but we'll need to update the other locales as well. Can @LlGC-szw help with that?

@LlGC-szw

Copy link
Copy Markdown

Happy to assist.

Comment thread src/locales/en-GB.json Outdated
@demiankatz

Copy link
Copy Markdown
Contributor

Happy to assist.

Thanks! What's the best way to do this? Do you want to just add the translations in a comment here so that @Geoffsc can insert them into the project, or do you want to push updates directly to the branch here?

@demiankatz demiankatz changed the title fix for #1074 Improve ambiguous "more info" label (fixes #1074) Oct 17, 2024
@LanieOkorodudu

LanieOkorodudu commented Oct 17, 2024

Copy link
Copy Markdown
Contributor

@Geoffsc @demiankatz I've tested the Vercel app, and everything looks good. Adding Universal Viewer under 'More Info' is a useful improvement. The only remaining is to translate it and include it in all the available languages in the settings. Once done, I'm happy to test it again.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everyone, looks like this is good to go!

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, except that something weird has happened and there are conflicts listed in all the language files...

@Geoffsc, let me know if you need help straightening this out. I wonder if it's something to do with line breaks or whitespace.

@Geoffsc

Geoffsc commented Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

Well, except that something weird has happened and there are conflicts listed in all the language files...

@Geoffsc, let me know if you need help straightening this out. I wonder if it's something to do with line breaks or whitespace.

I updated dev locally and merged it into this branch. It looks like the language files may have been updated in dev recently to address another issue. Do we know which one? In any case I think I can resolve by accepting the upstream change and then applying my updates since they're just one line per file.

image

@Geoffsc

Geoffsc commented Oct 18, 2024

Copy link
Copy Markdown
Contributor Author

@demiankatz this should be good to go now.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thanks for straightening that out, @Geoffsc!

@demiankatz demiankatz merged commit 261abe6 into UniversalViewer:dev Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Community Sprint COMPLETED

Development

Successfully merging this pull request may close these issues.

5 participants