The latest updates on your projects. Learn more about Vercel for Git ↗︎

@Saira-A, if this solves a problem, should we also add parallel behavior to the disableNextButton/enableNextButton methods so everything is consistent?

Like this? This causes another issue where the previous button becomes greyed out when on the last page. Otherwise it still has the runtime error that prevbutton had but it just loops back to the first page instead of going into negative numbers

disableNextButton(): void {
  this.nextButtonEnabled = false;
  this.$nextButton.disable();
  this.$prevButton.attr("disabled","disabled");
}

enableNextButton(): void {
  this.nextButtonEnabled = true;
  this.$nextButton.enable();
  this.$prevButton.removeAttr("disabled");
}

@Saira-A, if this solves a problem, should we also add parallel behavior to the disableNextButton/enableNextButton methods so everything is consistent?

Like this? This causes another issue where the previous button becomes greyed out when on the last page. Otherwise it still has the runtime error that prevbutton had but it just loops back to the first page instead of going into negative numbers

disableNextButton(): void {
  this.nextButtonEnabled = false;
  this.$nextButton.disable();
  this.$prevButton.attr("disabled","disabled");
}

enableNextButton(): void {
  this.nextButtonEnabled = true;
  this.$nextButton.enable();
  this.$prevButton.removeAttr("disabled");
}

@Saira-A, I think you just need to change "$prevButton" to "$nextButton" in that code snippet, so that the next button is disabled instead of the prev button. :-)

@Saira-A, if this solves a problem, should we also add parallel behavior to the disableNextButton/enableNextButton methods so everything is consistent?

Like this? This causes another issue where the previous button becomes greyed out when on the last page. Otherwise it still has the runtime error that prevbutton had but it just loops back to the first page instead of going into negative numbers

disableNextButton(): void {
  this.nextButtonEnabled = false;
  this.$nextButton.disable();
  this.$prevButton.attr("disabled","disabled");
}

enableNextButton(): void {
  this.nextButtonEnabled = true;
  this.$nextButton.enable();
  this.$prevButton.removeAttr("disabled");
}

@Saira-A, I think you just need to change "$prevButton" to "$nextButton" in that code snippet, so that the next button is disabled instead of the prev button. :-)

Oops, that would explain it! fixed

Thanks, @Saira-A! This makes sense to me if @LanieOkorodudu can't find any problems. :-)

I think the prev button still not working using the keyboard..

I think the prev button still not working using the keyboard..

It only works if you click the button first and then use the enter key, it doesn't use the left/right arrow keys if that's what you mean @LanieOkorodudu

I added the same to the first/last buttons, thanks @demiankatz

I think the prev button still not working using the keyboard..

It only works if you click the button first and then use the enter key, it doesn't use the left/right arrow keys if that's what you mean @LanieOkorodudu

I added the same to the first/last buttons, thanks @demiankatz

@Saira-A Yes that's what I mean but probably that's different issue to address. I just check it in vercel app and it's working now. Just as you said you have to initiate the click first then press enter key. This should address and solve the issue #888. Thanks again @Saira-A and @demiankatz