UV version:
universalviewer@4.2.0-rc3/4
I'm submitting a:
Current behavior:
In rc3/4 of 4.2.0 the embed URL is missing a ? after the # which causes the UV to error
Expected behavior:
Embedded Viewer would work
Steps to reproduce:
- Go to universalviewer.dev
- Open the share dialog and copy the URL from the embed box
- Paste into a new tab
- Manually add ? after the # and refresh to see it working
Related code:
In src/content-handlers/iiif/modules/uv-shared-module/BaseExtension.ts#buildEmbedScript()
if ((hashParams?.size ?? 0) > 0) {
appUri += `#${hashParams.toString()}`;
}
Other information:
Suggested fix:
if ((hashParams?.size ?? 0) > 0) {
appUri += `#?${hashParams.toString()}`;
}
UV version:
I'm submitting a:
Current behavior:
In rc3/4 of 4.2.0 the embed URL is missing a ? after the # which causes the UV to error
Expected behavior:
Embedded Viewer would work
Steps to reproduce:
Related code:
In
src/content-handlers/iiif/modules/uv-shared-module/BaseExtension.ts#buildEmbedScript()Other information:
Suggested fix: