Rename auth test files so pytest collects them#3944
Merged
lunkwill42 merged 1 commit intomasterfrom Mar 27, 2026
Merged
Conversation
The files `backends_tests.py` and `remote_user_tests.py` use a `*_tests.py` suffix which doesn't match pytest's default `test_*.py` or `*_test.py` patterns. They were silently skipped during normal test discovery.
|
10 tasks
aleksfl
approved these changes
Mar 27, 2026
johannaengland
approved these changes
Mar 27, 2026
Test results 7 files 7 suites 13m 53s ⏱️ Results for commit 612c216. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
+ Coverage 63.97% 64.06% +0.09%
==========================================
Files 627 627
Lines 46369 46386 +17
Branches 43 43
==========================================
+ Hits 29663 29718 +55
+ Misses 16696 16658 -38
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
backends_tests.pyandremote_user_tests.pyuse a*_tests.pysuffix that doesn't match pytest's default collection patterns (test_*.py/*_test.py), so they were silently skipped during test discovery. This renames both to*_test.py, matching the convention used in the rest of the repo. The directory now collects 15 tests instead of 3.Contributor Checklist
Added a changelog fragment for towncrierAdded/amended tests for new/changed codeAdded/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be doneIf it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)If this results in changes in the UI: Added screenshots of the before and afterIf this adds a new Python source code file: Added the boilerplate header to that file