Skip to content

Research why it is not possible to log in with social logins#3917

Closed
hmpf wants to merge 1 commit intomasterfrom
bug-on-dataporten-login
Closed

Research why it is not possible to log in with social logins#3917
hmpf wants to merge 1 commit intomasterfrom
bug-on-dataporten-login

Conversation

@hmpf
Copy link
Copy Markdown
Contributor

@hmpf hmpf commented Mar 25, 2026 •
edited
Loading

Scope and purpose

It is not possible to log in with dataporten currently. The regular expression in the Everyone-group is correct but we still get sent back to the login page.

This pull request

  • adds/changes/removes a dependency
  • changes the database
  • changes the API

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 25, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@hmpf hmpf changed the title add lots of logging in has_perm and authorize_request Research why it is not possible to log in with social logins Mar 25, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 25, 2026

Test results

    11 files      11 suites   17m 49s ⏱️
 2 927 tests  2 925 ✅ 0 💤  2 ❌
13 802 runs  13 790 ✅ 0 💤 12 ❌

For more details on these failures, see this check.

Results for commit 8fea7a0.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 25, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.95%. Comparing base (7d3f929) to head (8fea7a0).
⚠️ Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
python/nav/models/profiles.py 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3917      +/-   ##
==========================================
- Coverage   63.96%   63.95%   -0.02%     
==========================================
  Files         625      625              
  Lines       46336    46348      +12     
  Branches       43       43              
==========================================
  Hits        29640    29640              
- Misses      16686    16698      +12     
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hmpf
Copy link
Copy Markdown
Contributor Author

hmpf commented Mar 25, 2026

/accounts/password/reset/ also does not work, but that is fixable by adding "^/accounts/password/reset/" as web_access to the Everyone group.

@Simrayz Simrayz mentioned this pull request Mar 25, 2026
Merged
10 tasks
@hmpf
Copy link
Copy Markdown
Contributor Author

hmpf commented Mar 26, 2026

Fixed in #3924

@hmpf hmpf closed this Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hmpf @lunkwill42