Improve the design of the Account Connections page#3905
Conversation
Test results 13 files 13 suites 25m 6s ⏱️ Results for commit 4a90e30. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3905 +/- ##
==========================================
+ Coverage 63.89% 63.92% +0.03%
==========================================
Files 625 627 +2
Lines 46260 46293 +33
Branches 43 43
==========================================
+ Hits 29557 29594 +37
+ Misses 16693 16689 -4
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4946f0 to
9a71688
Compare
9a71688 to
4a90e30
Compare
|
|
Wut, allauth originally uses a radio input? Jeeez! |
hmpf
left a comment
There was a problem hiding this comment.
Code looks good, I'll give it a quick test.
| """Custom connections view that adds connected provider IDs to the context. | ||
|
|
||
| This allows the template to disable providers that the user has already | ||
| connected, preventing duplicate connections. | ||
| """ |
There was a problem hiding this comment.
One would think this feature is what one would usually want, and having more than one of the same provider per user is a special case.
Scope and purpose
Fixes #3873.
Improves the connections page styling and disables already-connected providers.
This pull request
Screenshots
Before
After
Contributor Checklist
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.