Test results

    13 files      13 suites   25m 10s ⏱️
 2 899 tests  2 899 ✅ 0 💤 0 ❌
16 950 runs  16 950 ✅ 0 💤 0 ❌

Results for commit 92c6b57.

♻️ This comment has been updated with latest results.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.83%. Comparing base (446fde8) to head (de1044f).
⚠️ Report is 18 commits behind head on master.

@@            Coverage Diff             @@
##           master    #3888      +/-   ##
==========================================
+ Coverage   63.74%   63.83%   +0.08%     
==========================================
  Files         624      624              
  Lines       46154    46175      +21     
  Branches       43       43              
==========================================
+ Hits        29421    29474      +53     
+ Misses      16723    16691      -32     
  Partials       10       10              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

I noticed that for other attributes (like parent) that a line is only added if the attribute is not null, so to follow that pattern I would only show this line if a location has aliases

Funnily enough in rooms that is not the case - in that case you should create a follow up issue with a discussion tag where we should talk about if that difference in behavior is wanted and if not, which approach to follow - always show all lines or only should the lines where the content is not empty

I noticed that for other attributes (like parent) that a line is only added if the attribute is not null, so to follow that pattern I would only show this line if a location has aliases

Funnily enough in rooms that is not the case - in that case you should create a follow up issue with a discussion tag where we should talk about if that difference in behavior is wanted and if not, which approach to follow - always show all lines or only should the lines where the content is not empty

done here #3893

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud