Skip to content

Add aliases to room details page#3887

Merged
aleksfl merged 1 commit intomasterfrom
feat/show-room-aliases-in-room-details-page
Mar 20, 2026
Merged

Add aliases to room details page#3887
aleksfl merged 1 commit intomasterfrom
feat/show-room-aliases-in-room-details-page

Conversation

@aleksfl
Copy link
Copy Markdown
Contributor

@aleksfl aleksfl commented Mar 19, 2026

Scope and purpose

Fixes #3840.
Before:
image

After:
with aliases
image
without
image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If this results in changes in the UI: Added screenshots of the before and after

@aleksfl aleksfl requested a review from a team March 19, 2026 14:19
@aleksfl aleksfl linked an issue Mar 19, 2026 that may be closed by this pull request
Show room aliases in room details page #3840
Closed
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026 •
edited
Loading

Test results

    13 files      13 suites   24m 11s ⏱️
 2 899 tests  2 899 ✅ 0 💤 0 ❌
16 950 runs  16 950 ✅ 0 💤 0 ❌

Results for commit f1db9bf.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 19, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.83%. Comparing base (446fde8) to head (f1db9bf).
⚠️ Report is 16 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3887      +/-   ##
==========================================
+ Coverage   63.74%   63.83%   +0.09%     
==========================================
  Files         624      624              
  Lines       46154    46175      +21     
  Branches       43       43              
==========================================
+ Hits        29421    29476      +55     
+ Misses      16723    16689      -34     
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aleksfl aleksfl self-assigned this Mar 20, 2026
johannaengland
johannaengland reviewed Mar 20, 2026
View reviewed changes
@aleksfl aleksfl requested a review from johannaengland March 20, 2026 09:21
@aleksfl aleksfl force-pushed the feat/show-room-aliases-in-room-details-page branch from 450f3ff to f1db9bf Compare March 20, 2026 09:37
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 20, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@aleksfl aleksfl merged commit ddd31a4 into master Mar 20, 2026
19 checks passed
@aleksfl aleksfl deleted the feat/show-room-aliases-in-room-details-page branch March 20, 2026 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johannaengland johannaengland johannaengland approved these changes

Assignees

@aleksfl aleksfl

Labels

frontend

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show room aliases in room details page

2 participants

@aleksfl @johannaengland