Add aliases to room/location string representation#3868
Merged
johannaengland merged 1 commit intoUninett:masterfrom Mar 19, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3868 +/- ##
=======================================
Coverage 63.74% 63.74%
=======================================
Files 624 624
Lines 46148 46154 +6
Branches 43 43
=======================================
+ Hits 29417 29421 +4
- Misses 16721 16723 +2
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
approved these changes
Mar 19, 2026
Contributor
hmpf
left a comment
There was a problem hiding this comment.
Approved, but needs follow-up issues as per f2f discussion
Simrayz
approved these changes
Mar 19, 2026
7f0a5b2 to
05aea9b
Compare
|
This was referenced Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
This was originally added in #3851 (also dependent on it), but since it sparked some discussion I decided to split it from there and create a separate PR where we can discuss it without blocking any other PRs.
This change influences:
This list is not exhaustive and should be filled out properly to make this an informed decision.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.