Skip to content

Allow and document allauth social accounts#3862

Merged
hmpf merged 3 commits intomasterfrom
allow-and-document-allauth-social-accounts
Mar 19, 2026
Merged

Allow and document allauth social accounts#3862
hmpf merged 3 commits intomasterfrom
allow-and-document-allauth-social-accounts

Conversation

@hmpf
Copy link
Copy Markdown
Contributor

@hmpf hmpf commented Mar 17, 2026 •
edited
Loading

Scope and purpose

Fixes #3813 for OIDC/OAuth2.

This pull request

  • adds/changes/removes a dependency

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@hmpf hmpf added documentation Related to documentation of NAV dependencies Pull requests that update a dependency file labels Mar 17, 2026
@hmpf hmpf self-assigned this Mar 17, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 17, 2026 •
edited
Loading

Test results

    14 files      14 suites   24m 37s ⏱️
 2 948 tests  2 948 ✅ 0 💤 0 ❌
16 860 runs  16 860 ✅ 0 💤 0 ❌

Results for commit 8512bac.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 17, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.73%. Comparing base (fdbde93) to head (746983c).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
- Coverage   63.73%   63.73%   -0.01%     
==========================================
  Files         624      624              
  Lines       46139    46139              
  Branches       43       43              
==========================================
- Hits        29408    29406       -2     
- Misses      16721    16723       +2     
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Simrayz
Simrayz requested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great docs! 😄 Adding socialaccount as a core dependency is a good change. I just have some typos and inconcistencies in the docs that need addressing.

great-scott

Comment thread doc/howto/allauth-and-oidc.rst Outdated
Comment thread doc/howto/allauth-and-oidc.rst Outdated
Comment thread doc/howto/allauth-and-oidc.rst Outdated
Comment thread doc/howto/allauth-and-oidc.rst Outdated
Comment thread doc/howto/allauth-and-oidc.rst Outdated
@hmpf hmpf requested review from a team and Simrayz March 18, 2026 11:03
Simrayz
Simrayz approved these changes Mar 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

hmpf added 3 commits March 19, 2026 10:07
@hmpf
Make django-allauth oidc an always-on dependency
1daa25c 
Lock in the Django app necessary for OIDC/OAuth2 and SAML-support.
@hmpf
Document support for OIDC/OAuth2 via a back door
83f29a4 
.. there's no NAV config for this, *yet*.
@hmpf
Add changelog fragment
746983c
@hmpf hmpf force-pushed the allow-and-document-allauth-social-accounts branch from 8512bac to 746983c Compare March 19, 2026 09:09
@hmpf hmpf merged commit b1df381 into master Mar 19, 2026
12 of 13 checks passed
@hmpf hmpf deleted the allow-and-document-allauth-social-accounts branch March 19, 2026 09:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 19, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simrayz Simrayz Simrayz approved these changes

Assignees

@hmpf hmpf

Labels

dependencies Pull requests that update a dependency file documentation Related to documentation of NAV

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

We need to document how to use Django settings to use allauth social providers (oidc/saml)

2 participants

@hmpf @Simrayz