Skip to content

Show alias in room list in SeedDB#3855

Merged
johannaengland merged 2 commits intoUninett:masterfrom
johannaengland:polish/show-alias-room-list-seeddb
Mar 19, 2026
Merged

Show alias in room list in SeedDB#3855
johannaengland merged 2 commits intoUninett:masterfrom
johannaengland:polish/show-alias-room-list-seeddb

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland commented Mar 16, 2026 •
edited
Loading

Scope and purpose

Fixes #3844. Dependent on #3851.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@johannaengland johannaengland requested review from a team, Simrayz and lunkwill42 March 16, 2026 15:02
@johannaengland johannaengland self-assigned this Mar 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 16, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.74%. Comparing base (cc3c158) to head (e816587).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3855   +/-   ##
=======================================
  Coverage   63.73%   63.74%           
=======================================
  Files         624      624           
  Lines       46145    46148    +3     
  Branches       43       43           
=======================================
+ Hits        29412    29415    +3     
  Misses      16723    16723           
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland changed the title Polish/show alias room list seeddb Show alias in room list in SeedDB Mar 17, 2026
Simrayz
Simrayz requested changes Mar 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good, we just need to handle the alias column name override :) See my suggestion for an approach to achieve this.

This PR should have been based on #3851, as it makes it a lot harder to review. I understand it is a limitation with forks, but worth to consider if there are more extensive dependencies later.

@johannaengland
Copy link
Copy Markdown
Contributor Author

johannaengland commented Mar 18, 2026

This PR should have been based on #3851, as it makes it a lot harder to review. I understand it is a limitation with forks, but worth to consider if there are more extensive dependencies later.

Yes, I agree - if I would've known that when working on #3851 I would have added this branch directly to this repo, but alas

@johannaengland johannaengland requested review from a team and Simrayz March 18, 2026 15:27
@johannaengland johannaengland marked this pull request as ready for review March 18, 2026 15:27
@johannaengland johannaengland mentioned this pull request Mar 18, 2026
Merged
10 tasks
Simrayz
Simrayz approved these changes Mar 19, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 😄

@johannaengland johannaengland force-pushed the polish/show-alias-room-list-seeddb branch from 14075c5 to e816587 Compare March 19, 2026 11:59
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 19, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@johannaengland johannaengland merged commit eb92f4c into Uninett:master Mar 19, 2026
15 checks passed
@johannaengland johannaengland deleted the polish/show-alias-room-list-seeddb branch March 19, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Simrayz Simrayz Simrayz approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

Assignees

@johannaengland johannaengland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Show room aliases in room list in SeedDB

2 participants

@johannaengland @Simrayz