Skip to content

Use room/location aliases in global/room/location search#3832

Merged
johannaengland merged 4 commits intoUninett:masterfrom
johannaengland:feature/use-aliases-in-search
Mar 13, 2026
Merged

Use room/location aliases in global/room/location search#3832
johannaengland merged 4 commits intoUninett:masterfrom
johannaengland:feature/use-aliases-in-search

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

Scope and purpose

Fixes #3821.

How to manually test:

  1. Add an alias to a room, another to a location. Add that location as a child to another location.
  2. Search for the alias in the search bar on top of every page. See that you're redirected to the detail page of the room/the location.
  3. Search for the alias of the room in the room search /search/room/. See that that room is listed in the result.
  4. Search for the alias of the location in the room search /search/room/. See that all the rooms that are in that location are listed.
  5. Search for the alias of the location in the location search /search/location/. See that both the location and it's parent are listed.

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@johannaengland johannaengland requested review from a team and hmpf March 11, 2026 15:17
@johannaengland johannaengland self-assigned this Mar 11, 2026
@johannaengland johannaengland changed the title Feature/use aliases in search Use room/location aliases in global/room/location search Mar 11, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.46%. Comparing base (7169ba2) to head (b86a1fa).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3832   +/-   ##
=======================================
  Coverage   63.46%   63.46%           
=======================================
  Files         624      624           
  Lines       46047    46049    +2     
  Branches       43       43           
=======================================
+ Hits        29223    29225    +2     
  Misses      16814    16814           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland force-pushed the feature/use-aliases-in-search branch from db89c96 to 9a61b64 Compare March 12, 2026 14:12
@johannaengland johannaengland force-pushed the feature/use-aliases-in-search branch from 9a61b64 to b86a1fa Compare March 12, 2026 14:33
@sonarqubecloud
Copy link
Copy Markdown

@johannaengland johannaengland merged commit afd3d95 into Uninett:master Mar 13, 2026
18 checks passed
@johannaengland johannaengland deleted the feature/use-aliases-in-search branch March 13, 2026 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use room/location aliases in room/location search

2 participants