Remove Python 3.12 from default test matrix#3763
Conversation
4187ccf to
1b1dbc8
Compare
This removes 3.12 from the tox envlist (i.e. you can still explicitly invoke it, but it won't run when all environments are selected) and from the GitHub Actions test matrix. This is mainly due to strange issues with race conditions and coverage measurements specifically on Python 3.12, that keep interfering with our CI on GitHub (i.e. even though all tests are green on 3.12, the test run fails because the coverage collector fails). We still test on 3.11 and 3.13, and never plan to run NAV in production on 3.12 on our end anyway.
1b1dbc8 to
a5a4dd1
Compare
|
Test results 21 files 21 suites 24m 28s ⏱️ Results for commit a5a4dd1. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.16.x #3763 +/- ##
==========================================
- Coverage 63.04% 63.00% -0.04%
==========================================
Files 614 614
Lines 45438 45438
Branches 43 43
==========================================
- Hits 28647 28629 -18
- Misses 16781 16799 +18
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| @@ -0,0 +1 @@ | |||
| Stopped CI testing on Python 3.12 by default | |||
There was a problem hiding this comment.
Sure, but that is more of a release notes thingy, methinks - and I didn't want to add those here, since this hits the 5.16 branch and I'm not sure if there will be another 5.16 release before 5.17.
Scope and purpose
Fixes #3741.
This removes 3.12 from the tox envlist (i.e. you can still explicitly invoke it, but it won't run when all environments are selected) and from the GitHub Actions test matrix.
This is mainly due to strange issues with race conditions and coverage measurements specifically on Python 3.12, that keep interfering with our CI on GitHub (i.e. even though all tests are green on 3.12, the test run fails because the coverage collector fails).
We still test on 3.11 and 3.13, and never plan to run NAV in production on 3.12 on our end anyway.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
Added/amended tests for new/changed codeAdded/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be doneIf it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)If this results in changes in the UI: Added screenshots of the before and afterIf this adds a new Python source code file: Added the boilerplate header to that file