Escape text in auditlog table to mitigate XSS vulnerability#3704
Merged
Escape text in auditlog table to mitigate XSS vulnerability#3704
Conversation
Test results 27 files 27 suites 45m 9s ⏱️ Results for commit c2363fc. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3704 +/- ##
==========================================
- Coverage 63.07% 63.07% -0.01%
==========================================
Files 612 612
Lines 45247 45247
Branches 43 43
==========================================
- Hits 28541 28539 -2
- Misses 16696 16698 +2
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
requested changes
Dec 16, 2025
Contributor
hmpf
left a comment
There was a problem hiding this comment.
You need to escape actor, target, object and summary.
hmpf
approved these changes
Dec 16, 2025
75fb800 to
e1ae6f1
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #2803
This PR adds HTML escaping to the auditlog table to mitigate the XSS vulnerability.
Screenshots
Before
After
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.