Merged
Conversation
This makes breadcrumbs show up again when editing JWT tokens
6b9076f to
e8e7f65
Compare
e8e7f65 to
2c7960c
Compare
Test results 27 files 27 suites 46m 1s ⏱️ Results for commit ba5efd6. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3689 +/- ##
==========================================
+ Coverage 63.07% 63.16% +0.09%
==========================================
Files 612 612
Lines 45237 45259 +22
Branches 43 43
==========================================
+ Hits 28531 28587 +56
+ Misses 16696 16662 -34
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Much cleaner this way, I think the original code was written before the constant existed.
2c7960c to
ba5efd6
Compare
|
johannaengland
approved these changes
Jan 26, 2026
Contributor
johannaengland
left a comment
There was a problem hiding this comment.
Works nicely, always good to have simpler code!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3682
This makes some big changes to the JWT Create and Edit views: They are changed from being
generic.Viewtogeneric.CreateViewandgeneric.EditViewrespectively. This gives us a lot of built in stuff, including breadcrumbs via theget_context_datafunction (we do this manually for callingrenderin the create view, but the context is automatically added for the edit view)The views are a bit cleaner now too, since a lot of things are done for free with the more specific views.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.