Add missing success messages in JWT views#3674
Merged
Conversation
Test results 27 files 27 suites 46m 13s ⏱️ Results for commit 5bbdb24. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3674 +/- ##
==========================================
+ Coverage 63.01% 63.04% +0.02%
==========================================
Files 612 612
Lines 45213 45230 +17
Branches 43 43
==========================================
+ Hits 28492 28516 +24
+ Misses 16711 16704 -7
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
80e2f6c to
c5e8f34
Compare
c5e8f34 to
7b05136
Compare
10 tasks
johannaengland
approved these changes
Dec 11, 2025
lunkwill42
approved these changes
Dec 11, 2025
Member
lunkwill42
left a comment
There was a problem hiding this comment.
@johannaengland's nitpick is on point. I have nothing else to add :)
7b05136 to
5bbdb24
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Saw that the Edit and Create views for JWT tokens are missing success messages. All views for legacy tokens have them and the other JWT views have them so I consider this to be somewhat of a bug.
By success message I mean this green box that shows up:
Also adds test for editing JWT token since that was missing and codecov failed since this PR makes changes to the edit view
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.