Refactor multi-bridge-mib machinery to async#3664
Merged
lunkwill42 merged 3 commits intomasterfrom Dec 5, 2025
Merged
Conversation
This refactors the existing parts of ipdevpoll's multi-bridge-mib machinery from using Twisted `@inlineCallbacks` or explicit Deferred callback handling to using pure coroutines, in preparation for upcoming SNMPv3 context changes that are needed. This is also in line with #3424
Test results 27 files 27 suites 46m 25s ⏱️ Results for commit 3811d68. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3664 +/- ##
==========================================
- Coverage 62.95% 62.94% -0.01%
==========================================
Files 611 611
Lines 45150 45145 -5
Branches 43 43
==========================================
- Hits 28424 28417 -7
- Misses 16716 16718 +2
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
`retrieve_alternate_bridge_mibs` is now an async function, and does not return a Deferred - so the test needed updating
|
johannaengland
approved these changes
Dec 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
This refactors the existing parts of ipdevpoll's multi-bridge-mib machinery from using Twisted
@inlineCallbacksor explicit Deferred callback handling to using pure coroutines, in preparation for upcoming SNMPv3 context changes that are needed (#2811). This is also in line with #3424.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
Added a changelog fragment for towncrierAdded/amended tests for new/changed codeAdded/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be doneIf it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)If this results in changes in the UI: Added screenshots of the before and afterIf this adds a new Python source code file: Added the boilerplate header to that file