Use path as parameter type for module name in Django path#3653
Merged
johannaengland merged 2 commits into5.15.xfrom Nov 17, 2025
Merged
Use path as parameter type for module name in Django path#3653johannaengland merged 2 commits into5.15.xfrom
path as parameter type for module name in Django path#3653johannaengland merged 2 commits into5.15.xfrom
Conversation
path as parameter type for module name in Django path
aleksfl
reviewed
Nov 14, 2025
Test results 27 files 27 suites 45m 26s ⏱️ Results for commit f9b8de3. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.15.x #3653 +/- ##
==========================================
+ Coverage 62.82% 62.88% +0.05%
==========================================
Files 611 611
Lines 45125 45125
Branches 43 43
==========================================
+ Hits 28349 28376 +27
+ Misses 16766 16739 -27
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simrayz
previously approved these changes
Nov 14, 2025
Contributor
Simrayz
left a comment
There was a problem hiding this comment.
Nice :D It's so satisfying when the fix is simple.
0490b98 to
00c87fd
Compare
50f8b16
50f8b16 to
87345cc
Compare
Regression test for #3652
Accessing ipdevinfo for IP devices having a module with / in name lead to internal server error
87345cc to
f9b8de3
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3652.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.