Support search by description in search providers#3647
Merged
Conversation
|
Test results 27 files 27 suites 45m 44s ⏱️ Results for commit 22325bc. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3647 +/- ##
==========================================
- Coverage 62.82% 62.82% -0.01%
==========================================
Files 611 611
Lines 45125 45127 +2
Branches 43 43
==========================================
Hits 28351 28351
- Misses 16764 16766 +2
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
johannaengland
approved these changes
Nov 10, 2025
| ) | ||
|
|
||
| @staticmethod | ||
| def assert_search_provider_result(instance: models.Model, provider_name: str): |
Contributor
There was a problem hiding this comment.
Oh, this is absolutely beautiful! Nice abstraction!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Resolves #3149
This PR adds support for searching by description in the main info search, for rooms, locations, vlans and device groups.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.