Skip to content

Upgrade multiselect library#3612

Merged
Simrayz merged 2 commits intochore/upgrade-jqueryfrom
chore/update-multiselect-library
Oct 24, 2025
Merged

Upgrade multiselect library#3612
Simrayz merged 2 commits intochore/upgrade-jqueryfrom
chore/update-multiselect-library

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Oct 17, 2025

Scope and purpose

This PR upgrades the jQuery MultiSelect library, as part of the larger #3582 jQuery update.

The multiselect element has been updated quite a bit, and there is no longer a left-and-right layout. It is closer to a combobox or the select2 used for search in other parts of the application.

How to test

API Tokens

  1. Open "User and API Administration" tool
  2. Select "API Token List", and edit on any token.
  3. Verify that there is a multiselect, and make changes.
  4. Save the form, and verify that the changes were commited.

JWT

  1. Open "User and API Administration" tool
  2. Select "API Token List", and create a new token.
  3. Verify that there is a multiselect, and make changes.
  4. Save the form, and click "Back to token list"
  5. Click on the name of the newly created token, and verify that the permissions you selected were added.

Screenshots

The library has changed the elements substantially, but the "After" uses the defaults from the library.

Before

image

After

image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Oct 17, 2025
@Simrayz Simrayz added javascript nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) labels Oct 17, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 17, 2025

Test results

    27 files      27 suites   46m 25s ⏱️
 2 618 tests  2 618 ✅ 0 💤 0 ❌
19 334 runs  19 334 ✅ 0 💤 0 ❌

Results for commit a129d3c.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.51%. Comparing base (332494d) to head (a129d3c).

Additional details and impacted files
@@                  Coverage Diff                  @@
##           chore/upgrade-jquery    #3612   +/-   ##
=====================================================
  Coverage                 62.51%   62.51%           
=====================================================
  Files                       611      611           
  Lines                     45020    45020           
  Branches                     43       43           
=====================================================
  Hits                      28142    28142           
  Misses                    16868    16868           
  Partials                     10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz force-pushed the chore/update-multiselect-library branch from 84817dc to 394c8f4 Compare October 17, 2025 12:10
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch 2 times, most recently from 1784f24 to ff7a839 Compare October 17, 2025 13:06
@Simrayz Simrayz force-pushed the chore/update-multiselect-library branch from 394c8f4 to 5ca04b2 Compare October 17, 2025 13:07
@Simrayz Simrayz force-pushed the chore/upgrade-jquery branch from ff7a839 to 332494d Compare October 17, 2025 13:49
@Simrayz Simrayz force-pushed the chore/update-multiselect-library branch from 5ca04b2 to a129d3c Compare October 17, 2025 13:50
@sonarqubecloud
Copy link
Copy Markdown

@Simrayz Simrayz changed the title Update multiselect library Upgrade multiselect library Oct 17, 2025
@Simrayz Simrayz requested a review from a team October 20, 2025 08:02
Copy link
Copy Markdown
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual test is fine.

@hmpf hmpf requested a review from a team October 20, 2025 11:15
@Simrayz Simrayz mentioned this pull request Oct 22, 2025
10 tasks
@Simrayz Simrayz merged commit 34d1bb6 into chore/upgrade-jquery Oct 24, 2025
19 checks passed
@Simrayz Simrayz deleted the chore/update-multiselect-library branch October 24, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

javascript nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants