Use HTMX for check connectivity functionality by Simrayz · Pull Request #3568 · Uninett/nav

Simrayz · 2025-10-01T07:38:55Z

Scope and purpose

Resolves #3560.

This PR replaces a complicated flow to check if an IP Device can connect to a given management profile. The javascript flow has been completely replaced with htmx templates and views, with a two step process:

A check is made to ensure that a valid IP address is provided, and that management profiles exist. This can result in either:
- If neither an address or profile is sent, an error message is returned.
- If the provided address is an invalid IP, but resolves to a hostname, a prompt to select an address is shown.
- If the IP is valid, the view returns a loader which triggers connectivity checks.
With a valid IP address and selected profiles, connectivity checks are run for each provided profile.
- The view returns a list of successful and failed connections.
- "Collected info" is updated with the resolved sysname and netbox type.

This pull request

Replaces javascript flow for checking connectivity with HTMX views and templates
Adds test coverage for check connectivity flow
Improves error messages returned by the connectivity tests

Screenshots

Form is disabled while running connectivity test. A loading spinner is shown .

Before

After. Uses an .htmx-indicator with a spinner gif instead of Spinner(...) class in JS

Connectivity check responses

Before	After	Comment
IP and profile validation
		Text was made slightly smaller to match other alerts in the form
		A select is shown if an invalid IP address is resolved to a hostname
		Selecting an address updates the IP address input
Connectivity tests
		A successful connection shows a success alert
		Adjusted error list items to take up less height, and removed superfluous words.
		Checks with multiple profiles shows both successful and erroneous connections
		Collected info is updated after a connectivity test completes, regardless of success or failure

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

github-actions · 2025-10-01T08:13:30Z

Test results

27 files 27 suites 45m 41s ⏱️
2 652 tests 2 652 ✅ 0 💤 0 ❌
19 606 runs 19 606 ✅ 0 💤 0 ❌

Results for commit 372e2db.

♻️ This comment has been updated with latest results.

codecov · 2025-10-01T08:13:53Z

Codecov Report

❌ Patch coverage is 89.13043% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 62.81%. Comparing base (bb1a777) to head (78f8274).
⚠️ Report is 210 commits behind head on master.

Files with missing lines	Patch %	Lines
python/nav/web/seeddb/page/netbox/edit.py	89.13%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3568      +/-   ##
==========================================
+ Coverage   62.66%   62.81%   +0.15%     
==========================================
  Files         611      611              
  Lines       45107    45125      +18     
  Branches       43       43              
==========================================
+ Hits        28267    28346      +79     
+ Misses      16830    16769      -61     
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

johannaengland

Functionality is great! Just nitpicks to tests

tests/integration/web/seeddb_netbox_test.py

Simrayz · 2025-10-15T10:14:28Z

@lunkwill42 Let me know when you have taken a look at this, and I can merge it :)

lunkwill42

This whole PR just gives me warm, fuzzy feelings 🫶

e527049 has a slight typo in the commit log 😉

Actually, while you're at it, can we also fix one slight thing that wasn't there before? Only profiles that fail are hyperlinked to their SeedDB page. Successful profiles are not hyperlinked. Why shouldn't they also be hyperlinked?

(A minor annoyance on my part has also always been that one can select any profile, but there is no way to go directly to see the profile details when you're unsure if you're selecting the right profile. You have to make multiple clicks to find the same profile by name in the Management Profile tab. Not sure what the UI could look like to make profile both selectable and also somehow hyperlinked so I can check their details. Feel free to make an issue out of this annoyance 😆)

python/nav/web/seeddb/page/netbox/edit.py

python/nav/web/templates/seeddb/_seeddb_check_connectivity_response.html

tests/integration/web/seeddb_netbox_test.py

Simrayz · 2025-10-16T13:58:07Z

This whole PR just gives me warm, fuzzy feelings 🫶

:D

e527049 has a slight typo in the commit log 😉

NPM sNPM spnm snmp. (All jokes aside, I can fix it when rebasing the fixups before merging)

Actually, while you're at it, can we also fix one slight thing that wasn't there before? Only profiles that fail are hyperlinked to their SeedDB page. Successful profiles are not hyperlinked. Why shouldn't they also be hyperlinked?

Added it :)

(A minor annoyance on my part has also always been that one can select any profile, but there is no way to go directly to see the profile details when you're unsure if you're selecting the right profile. You have to make multiple clicks to find the same profile by name in the Management Profile tab. Not sure what the UI could look like to make profile both selectable and also somehow hyperlinked so I can check their details. Feel free to make an issue out of this annoyance 😆)

I can look into it after merging this PR :) I'm not sure what kind of UX would be a good fit, but maybe selecting a profile adds it to a list, instead of using the select 2 labels.

lunkwill42

Great, just a nitpick on one error message!

python/nav/web/seeddb/page/netbox/edit.py

python/nav/web/templates/seeddb/_seeddb_check_connectivity_response.html

lunkwill42 · 2025-10-30T11:16:32Z

python/nav/web/seeddb/page/netbox/edit.py

+    if not is_valid_ip(ip_address, strict=True):
        return _handle_invalid_ip(request, ip_address)


Doesn't seem like it made much of a difference though... since your error handling routine tries to look up the string in DNS, and the resolver will actually be as lenient as to convert integer input values into something resembling an IP address. 52 still becomes 0.0.0.52 😆

lunkwill42 · 2025-10-30T11:32:45Z

I can look into it after merging this PR :) I'm not sure what kind of UX would be a good fit, but maybe selecting a profile adds it to a list, instead of using the select 2 labels.

Some experimentation to find a good UX would be nice. Not high priority, but make an issue out of it :)

sonarqubecloud · 2025-10-30T11:54:03Z

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

lunkwill42

🥳

Simrayz self-assigned this Oct 1, 2025

Simrayz added javascript modernisation htmx labels Oct 1, 2025

Simrayz force-pushed the feat/3560-use-htmx-for-check-connectivity branch from 3a1a0cd to 584c694 Compare October 1, 2025 07:49

Simrayz force-pushed the feat/3560-use-htmx-for-check-connectivity branch 3 times, most recently from 71fd92a to 8db0ab6 Compare October 1, 2025 14:49

Simrayz marked this pull request as ready for review October 2, 2025 09:24

Simrayz requested a review from a team October 2, 2025 09:25

johannaengland requested changes Oct 7, 2025

View reviewed changes

Simrayz force-pushed the feat/3560-use-htmx-for-check-connectivity branch from f4b13e6 to 46ff1d9 Compare October 8, 2025 09:08

Simrayz requested a review from johannaengland October 8, 2025 09:09

johannaengland approved these changes Oct 10, 2025

View reviewed changes

Simrayz force-pushed the feat/3560-use-htmx-for-check-connectivity branch from 46ff1d9 to e527049 Compare October 10, 2025 11:51

lunkwill42 requested changes Oct 16, 2025

View reviewed changes

Simrayz requested a review from lunkwill42 October 21, 2025 08:58

lunkwill42 requested changes Oct 30, 2025

View reviewed changes

Simrayz added 7 commits October 30, 2025 12:51

Add views for handling check connectivity with htmx

8dea5f6

Add initial tests for seeddb check connectivity

0f856e8

Remove connectivity check plugins

9111943

Support collected info in htmx response

6dc020d

Add test coverage for check connectivity views

b823f20

Add changelog entry

c1c89d9

Improve error handling in connectivity test

e167b6e

Simrayz added 2 commits October 30, 2025 12:52

Add additional coverage for snpm connection tests

28ca9d8

Add link to profile in successful results

78f8274

Simrayz force-pushed the feat/3560-use-htmx-for-check-connectivity branch from 372e2db to 78f8274 Compare October 30, 2025 11:53

Simrayz requested a review from lunkwill42 October 30, 2025 11:53

Simrayz mentioned this pull request Oct 30, 2025

Selected management profiles in check connectivity should be hyperlinked #3643

Closed

lunkwill42 approved these changes Oct 30, 2025

View reviewed changes

Simrayz merged commit 5eaae6b into master Oct 30, 2025
16 checks passed

Simrayz deleted the feat/3560-use-htmx-for-check-connectivity branch October 30, 2025 12:10

johannaengland mentioned this pull request Dec 15, 2025

[BUG] NAV 5.15 asks for management profile for SRV #3694

Closed

		if not is_valid_ip(ip_address, strict=True):
		return _handle_invalid_ip(request, ip_address)

Conversation

Simrayz commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Scope and purpose

This pull request

Screenshots

Form is disabled while running connectivity test. A loading spinner is shown .

Connectivity check responses

Contributor Checklist

Uh oh!

github-actions bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test results

Uh oh!

codecov bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

johannaengland left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Simrayz commented Oct 15, 2025

Uh oh!

lunkwill42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Simrayz commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lunkwill42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lunkwill42 Oct 30, 2025

Choose a reason for hiding this comment

Uh oh!

lunkwill42 commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonarqubecloud bot commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Quality Gate passed

Uh oh!

lunkwill42 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Simrayz commented Oct 1, 2025 •

edited

Loading

github-actions bot commented Oct 1, 2025 •

edited

Loading

codecov bot commented Oct 1, 2025 •

edited

Loading

Simrayz commented Oct 16, 2025 •

edited

Loading

lunkwill42 commented Oct 30, 2025 •

edited

Loading

sonarqubecloud bot commented Oct 30, 2025 •

edited

Loading