Strip null-bytes from bytestrings being made safe for PostgreSQL#3552
Strip null-bytes from bytestrings being made safe for PostgreSQL#3552lunkwill42 merged 2 commits into5.14.xfrom
Conversation
PostgreSQL croaks on these. For #2479 --------- Co-authored-by: Hanne Moa <hanne.moa@sikt.no>
|
Test results 12 files 12 suites 12m 30s ⏱️ Results for commit b18ae32. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.14.x #3552 +/- ##
=======================================
Coverage 61.29% 61.29%
=======================================
Files 610 610
Lines 44724 44725 +1
Branches 43 43
=======================================
+ Hits 27412 27413 +1
Misses 17302 17302
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Change from #3539: made the stripping happen only once, combined the changelog commits into one, reworded commit messages. |
|
@lunkwill42 is this good enough or do you want to do something else with misbehaving servers/MIBs? We still need to save PostgreSQL from null-bytes though. |
lunkwill42
left a comment
There was a problem hiding this comment.
This looks absolutely fine to me. My thanks to @paulopamplona as well :)
Scope and purpose
Fixes #2479. Replaces #3539.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
[ ] Added/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.[ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done[ ] If this results in changes in the UI: Added screenshots of the before and after[ ] If this adds a new Python source code file: Added the boilerplate header to that file