Skip to content

Replace native tooltips with new nav tooltip#3522

Merged
Simrayz merged 6 commits intomasterfrom
chore/3482-replace-native-tooltips-with-nav-tooltip
Sep 9, 2025
Merged

Replace native tooltips with new nav tooltip#3522
Simrayz merged 6 commits intomasterfrom
chore/3482-replace-native-tooltips-with-nav-tooltip

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Sep 8, 2025

Scope and purpose

Resolves #3482.

Replaces all uses of icons with title attributes, and a single "dropdown" tooltip, with the new .nav-tooltip tooltip component.

The "Grant privileges" tooltip in the Group Privileges form has been modified slightly:

  • The tooltip trigger has been changed to include "How to guide", to signify that it is a link to an external resource.
  • The tooltip trigger has been changed to be a clickable link, instead of requiring a click inside the tooltip (which is a temporary element).
  • The "how to guide" anchor has been replaced with emphasis, and inclusion in the tooltip trigger text.

I have not been able to setup local JWT tokens (and as such can not visually verify the tooltip), but the change follows the standard of all other tooltips.

This pull request

  • Replaces tooltips in User and API Administration tool
    • Group details
    • Token details
    • JWT details
  • Replaces "Test description" tooltips in Watchdog tool

Screenshots

Before

Group permissions: Grant privileges "How to"
http://localhost:8000/useradmin/group/3/

image

Token details
http://localhost:8000/useradmin/tokens/detail/2/

image

Watchdog Test descriptions
http://localhost:8000/watchdog/

image

After

Group permissions: Grant privileges "How to"
http://localhost:8000/useradmin/group/3/

image

Token details
http://localhost:8000/useradmin/tokens/detail/2/

image

Watchdog Test descriptions
http://localhost:8000/watchdog/

image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • This pull request is based on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Sep 8, 2025

@Simrayz Simrayz changed the title Chore/3482 replace native tooltips with nav tooltip Replace native tooltips with new nav tooltip Sep 8, 2025
@Simrayz Simrayz requested a review from a team September 8, 2025 14:05
@Simrayz Simrayz self-assigned this Sep 8, 2025
@Simrayz Simrayz added the cleanup label Sep 8, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 8, 2025

Test results

   12 files     12 suites   12m 35s ⏱️
2 459 tests 2 459 ✅ 0 💤 0 ❌
6 912 runs  6 912 ✅ 0 💤 0 ❌

Results for commit f22fc71.

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.61%. Comparing base (1f74751) to head (f22fc71).
⚠️ Report is 318 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3522   +/-   ##
=======================================
  Coverage   61.61%   61.61%           
=======================================
  Files         611      611           
  Lines       44813    44813           
  Branches       43       43           
=======================================
  Hits        27610    27610           
  Misses      17193    17193           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works.

Easiest to test by going to to /useradmin/, pick any normal user, click a group to get to the group details, see "Grant privileges".

@Simrayz Simrayz merged commit dfff9de into master Sep 9, 2025
18 checks passed
@Simrayz Simrayz deleted the chore/3482-replace-native-tooltips-with-nav-tooltip branch September 9, 2025 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Standardize on the same tooltip style and method throughout

2 participants