Replace native tooltips with new nav tooltip#3522
Merged
Conversation
|
Test results 12 files 12 suites 12m 35s ⏱️ Results for commit f22fc71. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3522 +/- ##
=======================================
Coverage 61.61% 61.61%
=======================================
Files 611 611
Lines 44813 44813
Branches 43 43
=======================================
Hits 27610 27610
Misses 17193 17193
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
approved these changes
Sep 9, 2025
Contributor
hmpf
left a comment
There was a problem hiding this comment.
Works.
Easiest to test by going to to /useradmin/, pick any normal user, click a group to get to the group details, see "Grant privileges".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
Resolves #3482.
Replaces all uses of icons with
titleattributes, and a single "dropdown" tooltip, with the new.nav-tooltiptooltip component.The "Grant privileges" tooltip in the Group Privileges form has been modified slightly:
I have not been able to setup local JWT tokens (and as such can not visually verify the tooltip), but the change follows the standard of all other tooltips.
This pull request
Screenshots
Before
Group permissions: Grant privileges "How to"
http://localhost:8000/useradmin/group/3/
Token details
http://localhost:8000/useradmin/tokens/detail/2/
Watchdog Test descriptions
http://localhost:8000/watchdog/
After
Group permissions: Grant privileges "How to"
http://localhost:8000/useradmin/group/3/
Token details
http://localhost:8000/useradmin/tokens/detail/2/
Watchdog Test descriptions
http://localhost:8000/watchdog/
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.