Fix all-time searches in radius tool#3507
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 5.14.x #3507 +/- ##
==========================================
+ Coverage 61.05% 61.28% +0.22%
==========================================
Files 610 610
Lines 44711 44713 +2
Branches 43 43
==========================================
+ Hits 27300 27401 +101
+ Misses 17401 17302 -99
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
In the case of all-time searches cleaned_data["time"] is []
18403fe to
a0f0a1b
Compare
There was a problem hiding this comment.
Tested and working 😄 This will be helpful when replacing the details modal.
My only (quite optional) suggestion is to use dictionaries for the parameters instead, and use urlencode,
e.g.
url = reverse('some-url')
params = {
'query_0': 'username',
'query_1': admin_username,
'time_0': 'days',
'time_1': 123123123123,
'port_type': '',
'send': 'Search'
}
url = url + '?' + urlencode(params)This increases the readability of the code and makes it easier to identify the difference between the passed paramteres. However, this is obviously more verbose than using query strings, so feel free to merge.
That is a really good suggestion! Will do! |
d4962e6 to
1e89ca7
Compare
|
Scope and purpose
Fixes #3500.
Reason for this bug: In the case of all-time searches
cleaned_data["time"]is[].Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.