Add fit-content size to support large modal content#3502
Merged
Conversation
Test results 12 files 12 suites 12m 23s ⏱️ Results for commit 883f98d. ♻️ This comment has been updated with latest results. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3502 +/- ##
=======================================
Coverage 61.22% 61.22%
=======================================
Files 611 611
Lines 44754 44754
Branches 43 43
=======================================
Hits 27402 27402
Misses 17342 17342
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
780aca7 to
883f98d
Compare
|
9 tasks
johannaengland
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
This PR adds a new size option to modals,
fit-content, which allows modals to grow as wide as they need.As an example, this is necessary to support a wider "Add widget" modal on the dashboard, as demonstrated in #3487.
See provided screenshot for the effect this change would have.
This pull request
fit-content, to support larger contentfit-contentas default modal size (wastiny)Screenshots
With the new default (.fit-content), the "Add widget" modal would look like this:

Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.