Add tests for ipdevinfo refresh jobs functions#3496
Merged
johannaengland merged 1 commit intoUninett:masterfrom Sep 3, 2025
Merged
Add tests for ipdevinfo refresh jobs functions#3496johannaengland merged 1 commit intoUninett:masterfrom
johannaengland merged 1 commit intoUninett:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3496 +/- ##
==========================================
+ Coverage 61.09% 61.16% +0.07%
==========================================
Files 610 610
Lines 44715 44715
Branches 43 43
==========================================
+ Hits 27319 27352 +33
+ Misses 17386 17353 -33
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Simrayz
approved these changes
Sep 2, 2025
Contributor
Simrayz
left a comment
There was a problem hiding this comment.
LGTM.
Nitpick/considerations: I like organizing tests under a single class, and then omit the name of the function I'm testing. Also using variations of given/when/then as suggested to me earlier is a good convention.
c5c436f to
a80d755
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3448.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
Added/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.