Skip to content

Remove unused Foundation component stylesheets#3480

Merged
lunkwill42 merged 2 commits intomasterfrom
chore/3479-remove-unused-foundation-stylesheets
Aug 29, 2025
Merged

Remove unused Foundation component stylesheets#3480
lunkwill42 merged 2 commits intomasterfrom
chore/3479-remove-unused-foundation-stylesheets

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Aug 28, 2025

Scope and purpose

Fixes #3479 as part of Foundation cleanup.

I have gone through the Foundation 5 documentation, and identified components we are not using in the codebase. Some components are not used in any form, while two components (Split- and Dropdown Buttons) are currently unused, but we might want to utilize them.

I added removal of Split- and Dropdown Buttons as a separate commit, and leave the decision of removal up to the reviewers. There are multiple usages of dropdowns in the codebase, but they are all using div or a tags for the trigger, and as such don't take advantage of the styles.

See #3479 for a full list of components and where to find them.

This pull request

  • Removes all unused Foundation component stylesheets
  • Removes all unused Foundation button component stylesheets

Contributor Checklist

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • This pull request is based on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz requested a review from a team August 28, 2025 12:22
@Simrayz Simrayz self-assigned this Aug 28, 2025
@Simrayz Simrayz changed the title Chore/3479 remove unused foundation stylesheets Remove unused Foundation component stylesheets Aug 28, 2025
@sonarqubecloud
Copy link
Copy Markdown

@github-actions
Copy link
Copy Markdown

Test results

   12 files     12 suites   11m 58s ⏱️
2 366 tests 2 366 ✅ 0 💤 0 ❌
6 633 runs  6 633 ✅ 0 💤 0 ❌

Results for commit 200773a.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.04%. Comparing base (0279150) to head (200773a).
⚠️ Report is 387 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3480   +/-   ##
=======================================
  Coverage   61.04%   61.04%           
=======================================
  Files         610      610           
  Lines       44708    44708           
  Branches       43       43           
=======================================
  Hits        27294    27294           
  Misses      17404    17404           
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@johannaengland johannaengland requested review from a team and removed request for a team August 29, 2025 08:30
Copy link
Copy Markdown
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@hmpf hmpf requested a review from a team August 29, 2025 09:49
@lunkwill42 lunkwill42 merged commit c5867ab into master Aug 29, 2025
18 checks passed
@lunkwill42 lunkwill42 deleted the chore/3479-remove-unused-foundation-stylesheets branch August 29, 2025 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove unused Foundation stylesheets

3 participants