Replace foundation Topbar JS with jQuery#3478
Merged
Conversation
ab49e91 to
72aa156
Compare
|
Test results 12 files 12 suites 12m 22s ⏱️ Results for commit 72aa156. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3478 +/- ##
=======================================
Coverage 61.04% 61.04%
=======================================
Files 610 610
Lines 44708 44708
Branches 43 43
=======================================
Hits 27294 27294
Misses 17404 17404
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hmpf
approved these changes
Aug 29, 2025
Contributor
hmpf
left a comment
There was a problem hiding this comment.
I wonder if this is doable with pure CSS now...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3476, as part of #2972.
This PR replaces usages of
[data-topbar]with a jQuery implementation. All the plugin did was to toggle the.expandedclass on the.top-barcontainer, and remove the class if the screen resizes.This pull request
Contributor Checklist
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.