Skip to content

Replace foundation equalizer with jquery#3460

Merged
Simrayz merged 1 commit intomasterfrom
chore/replace-netmap-foundation-equalizer-with-jquery
Aug 29, 2025
Merged

Replace foundation equalizer with jquery#3460
Simrayz merged 1 commit intomasterfrom
chore/replace-netmap-foundation-equalizer-with-jquery

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Aug 22, 2025 •
edited
Loading

Scope and purpose

Part of #2972. Resolves #3459.

Replaces a small piece of foundation with a jquery implementation. It could probably be replaced by some simple Alpine/Hyperscript later.

You can view the changes in the Netmap tool. The "View options" button shows a panel, and makes sure that all elements have the same height (equalizing).

image

This pull request

  • Replaces the foundation equalizer in control view with a jquery implementation

Removes this line of foundation js:

nav/python/nav/web/static/js/src/netmap/control_view.js

Line 129 in 813b12a

$(document).foundation('equalizer', 'reflow');

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • This pull request is based on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz self-assigned this Aug 22, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Aug 22, 2025 •
edited
Loading

Test results

   12 files     12 suites   12m 16s ⏱️
2 366 tests 2 366 ✅ 0 💤 0 ❌
6 633 runs  6 633 ✅ 0 💤 0 ❌

Results for commit 90605a2.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.02%. Comparing base (9140a8a) to head (3709108).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3460      +/-   ##
==========================================
+ Coverage   60.99%   61.02%   +0.02%     
==========================================
  Files         610      610              
  Lines       44589    44707     +118     
  Branches       43       43              
==========================================
+ Hits        27199    27282      +83     
- Misses      17380    17415      +35     
  Partials       10       10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Simrayz Simrayz force-pushed the chore/replace-netmap-foundation-equalizer-with-jquery branch from 2a7ee06 to 3709108 Compare August 24, 2025 16:14
@Simrayz Simrayz marked this pull request as ready for review August 25, 2025 14:29
@Simrayz Simrayz linked an issue Aug 28, 2025 that may be closed by this pull request
Remove Equalizer JS #3477
Closed
@Simrayz Simrayz force-pushed the chore/replace-netmap-foundation-equalizer-with-jquery branch from 3709108 to 90605a2 Compare August 28, 2025 10:57
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Aug 28, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

johannaengland
johannaengland reviewed Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add to the PR description where I can find where this code is used? So that I can compare the look/behavior before and afterwards

@Simrayz
Copy link
Copy Markdown
Contributor Author

Simrayz commented Aug 29, 2025

Could you add to the PR description where I can find where this code is used? So that I can compare the look/behavior before and afterwards

@johannaengland Added a description of where to find the change + screenshot

@Simrayz Simrayz merged commit e6b9f1a into master Aug 29, 2025
15 checks passed
@Simrayz Simrayz deleted the chore/replace-netmap-foundation-equalizer-with-jquery branch December 15, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@johannaengland johannaengland johannaengland approved these changes

@lunkwill42 lunkwill42 Awaiting requested review from lunkwill42

Assignees

@Simrayz Simrayz

Labels

cleanup javascript

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Equalizer JS Replace equalizer in Netmap control view

3 participants

@Simrayz @johannaengland @lunkwill42