Make it possible to switch between SVG and PNG QR codes#3414
Merged
johannaengland merged 4 commits intoUninett:masterfrom Aug 15, 2025
Merged
Make it possible to switch between SVG and PNG QR codes#3414johannaengland merged 4 commits intoUninett:masterfrom
johannaengland merged 4 commits intoUninett:masterfrom
Conversation
d7d5a25 to
2ae2af8
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3414 +/- ##
==========================================
+ Coverage 60.85% 60.86% +0.01%
==========================================
Files 608 608
Lines 44198 44237 +39
Branches 48 48
==========================================
+ Hits 26896 26927 +31
- Misses 17290 17298 +8
Partials 12 12 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
lunkwill42
requested changes
Aug 11, 2025
Member
|
I don't see any reason why this should still be labeled as blocked, so I removed it. |
2ae2af8 to
f23adeb
Compare
lunkwill42
approved these changes
Aug 14, 2025
f23adeb to
0a7cffe
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Closes #2916. Dependent on #2897 and #2899.
Adds a config option
qr_codes.file_formatthat gives the option to switch between generating QR codes as SVG or PNG files.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
we don't currently have any documentation for QR codes - should I add some? And if so, where?
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.