Merged
Conversation
Django 4.2 changed the default of the internationalization setting USE_L10N from False to True. NAV prefers ISO timestamps in most of its UI, and since Django 4.2 was introduced in NAV 5.13, the way timestamps are printed, interpreted and sorted changed all over the UI. This explicitly sets USE_L10N to False to restore NAV's original behavior.
|
Test results 12 files 12 suites 11m 48s ⏱️ Results for commit 7bbbcaa. |
9 tasks
johannaengland
approved these changes
Jul 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3412 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and purpose
Fixes #3369
Django 4.2 changed the default of the internationalization setting
USE_L10NfromFalsetoTrue. NAV prefers ISO timestamps in most of its UI, and since Django 4.2 was introduced in NAV 5.13, the way timestamps are printed, interpreted and sorted changed all over the UI.This explicitly sets
USE_L10NtoFalseto restore NAV's original behavior.Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
[ ] Added/amended tests for new/changed code[ ] Added/changed documentation<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.[ ] If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done[ ] If this results in changes in the UI: Added screenshots of the before and after[ ] If this adds a new Python source code file: Added the boilerplate header to that file