Use flat_form template for more forms#3395
Merged
johannaengland merged 1 commit intoUninett:masterfrom Jul 30, 2025
Merged
Conversation
|
lunkwill42
approved these changes
Jul 29, 2025
6b4fcbb to
a7852cb
Compare
a7852cb to
473ec5b
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3395 +/- ##
==============================
==============================
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These forms could be refactored to use the
flat_formtemplate to automatically have a csrf token and also to look more uniform.Another part of working on Uninett/campus-tasks#45
SensorRangeForm: http://localhost/ipdevinfo/sensor/2400 (removes ":" in field labels)
BooleanSensorForm: http://localhost/ipdevinfo/sensor/1485
ChangePasswordForm: http://localhost/preferences/
ServiceChoiceForm: http://localhost/seeddb/service/add/