Skip to content

Add csrf token to forms in alert profiles#3367

Merged
johannaengland merged 1 commit intoUninett:masterfrom
johannaengland:refactor/csrf-alertprofiles
Jul 29, 2025
Merged

Add csrf token to forms in alert profiles#3367
johannaengland merged 1 commit intoUninett:masterfrom
johannaengland:refactor/csrf-alertprofiles

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

Contributes to https://github.com/Uninett/campus-tasks/issues/45.

Where to find the forms (ordered by commit):

Language form: Go to http://localhost/alertprofiles/, click on "Groups and permissions", see language dropdown

Base list form: Applies to multiple sides, but e.g. see http://localhost/alertprofiles/address/ (right below "Add address" button)

Profile form: http://localhost/alertprofiles/profile/ (right below "Profiles" heading)

Add subscription form: http://localhost/alertprofiles/profile/time-period/\<id>/subscriptions/, under "Add new expression"

Remove subscription form: http://localhost/alertprofiles/profile/time-period/\<id>/subscriptions/, when having added a subscription, under "For profile 'name'. Time period ..."

Delete time period from alert profile form: http://localhost/alertprofiles/profile/ and select or create a profile, see form under "Time Periods" heading

Remove expression from filter form: http://localhost/alertprofiles/filters/ and select or create a filter, see form under "Expression" heading

Add expression to filter form: http://localhost/alertprofiles/filters/ and select or create a filter, see form under "Add another expression to this filter"

Save expression to filter form: Same as previous, only click "Build expression" and see under "Add expression"
Permission form: http://localhost/alertprofiles/permissions/, click on a group, see form around "Set permissions for group name"

@johannaengland johannaengland requested a review from a team May 9, 2025 09:30
@johannaengland johannaengland self-assigned this May 9, 2025
@johannaengland johannaengland added the nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes) label May 9, 2025
@johannaengland johannaengland force-pushed the refactor/csrf-alertprofiles branch from fab4f6a to 179f6dc Compare May 9, 2025 09:32
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 9, 2025

@johannaengland johannaengland force-pushed the refactor/csrf-alertprofiles branch from 179f6dc to b16377f Compare July 29, 2025 12:58
@sonarqubecloud
Copy link
Copy Markdown

@johannaengland johannaengland merged commit 675b98a into Uninett:master Jul 29, 2025
13 checks passed
@johannaengland johannaengland deleted the refactor/csrf-alertprofiles branch July 29, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

nonews No news fragment is necessary for this PR (e.g. refactoring, cleanups, workflow/development changes)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants