Skip to content

Remove unused ColumnsForm#3280

Merged
johannaengland merged 1 commit intoUninett:masterfrom
johannaengland:cleanup/remove-columns-form-preferences
May 6, 2025
Merged

Remove unused ColumnsForm#3280
johannaengland merged 1 commit intoUninett:masterfrom
johannaengland:cleanup/remove-columns-form-preferences

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland commented Feb 19, 2025

Every dashboard has its own setting on how many columns it has

Closes #3243.

I did some digging and this has not been in use since 2016 (c7cebd9)

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (4b51056) to head (187d8b6).
Report is 2 commits behind head on master.

Additional details and impacted files
@@      Coverage Diff       @@
##   master   #3280   +/-   ##
==============================
==============================

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@hmpf hmpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to set up nav again to be able to test this, so that'll take a while. Codewise it looks fine though.

@johannaengland johannaengland force-pushed the cleanup/remove-columns-form-preferences branch from 18effa1 to f953ba4 Compare March 7, 2025 09:26
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Mar 7, 2025

Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for me. Just a nitpick on file naming (which causes me to want to look at our migration system, but that's another issue)

@johannaengland johannaengland requested review from hmpf and lunkwill42 May 5, 2025 13:10
Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Every dashboard has its own setting on how many columns it has
@johannaengland johannaengland force-pushed the cleanup/remove-columns-form-preferences branch from 2352bbf to 187d8b6 Compare May 6, 2025 08:43
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 6, 2025

@johannaengland johannaengland merged commit 41f9e31 into Uninett:master May 6, 2025
13 checks passed
@johannaengland johannaengland deleted the cleanup/remove-columns-form-preferences branch May 6, 2025 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Setting number of widgets via ColumnsForm in preferences seems to do nothing

3 participants