🦙 MegaLinter status: ✅ SUCCESS

See detailed report in MegaLinter reports

MegaLinter is graciously provided by

Test results

    8 files      8 suites   8m 21s ⏱️
2 047 tests 2 047 ✅  0 💤 0 ❌
3 920 runs  3 910 ✅ 10 💤 0 ❌

Results for commit 1c396cf.

♻️ This comment has been updated with latest results.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.44%. Comparing base (9c2586f) to head (1c396cf).
Report is 276 commits behind head on master.

@@           Coverage Diff           @@
##           master    #3105   +/-   ##
=======================================
  Coverage   60.44%   60.44%           
=======================================
  Files         605      605           
  Lines       43757    43757           
  Branches       48       48           
=======================================
  Hits        26451    26451           
  Misses      17294    17294           
  Partials       12       12           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This is an interesting form to refactor. Those forms are quite simple and both self.attrs = set_flat_form_attributes() in forms.py are redundant if combined with suggested changes in the templates (see below).

I originally added the {% if form.attrs %}...{% else %}{{ form }}{% endif %} logic to non-crispy templates purely as a failsafe - if we miss something out, at least basic (no styling and no customization in tag structure) form fields will be rendered. It does add redundancy. So we might need to consider if and when to drop those if else blocks in uncrispyfyed templates.. In this PR there was no crispy helper defined so we use set_flat_form_attributes() just for if else blocks in the template. So if we are going to drop extra failsaving, this PR is a good place to start this discussion

I have removed all of these if-else blocks in #3128. But we can also already do it now bit by bit, I don't really have a preference.

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud