Skip to content

Drop support for Python 3.7#2901

Merged
lunkwill42 merged 9 commits intoUninett:masterfrom
johannaengland:remove-python37-from-test-matrix
Jul 2, 2024
Merged

Drop support for Python 3.7#2901
lunkwill42 merged 9 commits intoUninett:masterfrom
johannaengland:remove-python37-from-test-matrix

Conversation

@johannaengland
Copy link
Copy Markdown
Contributor

@johannaengland johannaengland commented May 8, 2024 •
edited by lunkwill42
Loading

This closes #2891 and is one step in fixing #2790. Can only be merged once we have released NAV 5.10.

The things Codecov complains about are fixed in #2903.

The things this PR does:

  1. Update docker, tox, readthedocs, sonarcloud, Github workflows to not use Python 3.7 and only Python 3.9/3.10.
  2. Upgrade dependencies that were stuck to an old version due to it being the last one supporting Python 3.7.
  3. Update docs and pyproject.toml to mention minimum requirement of Python 3.9.

@johannaengland johannaengland added deprecation dependencies Pull requests that update a dependency file labels May 8, 2024
@johannaengland johannaengland self-assigned this May 8, 2024
@github-actions
Copy link
Copy Markdown

github-actions bot commented May 8, 2024

Test results

       9 files         9 suites   7m 39s ⏱️
3 320 tests 3 320 ✔️ 0 💤 0 ❌
6 379 runs  6 379 ✔️ 0 💤 0 ❌

Results for commit 4088f09.

@codecov
Copy link
Copy Markdown

codecov bot commented May 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.19%. Comparing base (35f1a9b) to head (4088f09).
Report is 348 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #2901      +/-   ##
==========================================
- Coverage   60.20%   60.19%   -0.02%     
==========================================
  Files         601      601              
  Lines       43981    43981              
==========================================
- Hits        26480    26475       -5     
- Misses      17501    17506       +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland johannaengland mentioned this pull request May 8, 2024
Closed
This was referenced May 8, 2024
Merged
Merged
Merged
Merged
Merged
Closed
@lunkwill42
Copy link
Copy Markdown
Member

lunkwill42 commented May 21, 2024

This closes #2891 and is one step in fixing #2790. Can only be merged once we have released NAV 3.11.

I assume you mean NAV 5.10 ? 5.11 is the first release that will no longer support Pythons < 3.9.

@lunkwill42 lunkwill42 mentioned this pull request Jul 2, 2024
Closed
lunkwill42
lunkwill42 approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ ⭐ ⭐

@lunkwill42 lunkwill42 merged commit 9840454 into Uninett:master Jul 2, 2024
@lunkwill42 lunkwill42 mentioned this pull request Jul 2, 2024
Closed
6 tasks
@johannaengland johannaengland deleted the remove-python37-from-test-matrix branch September 18, 2024 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lunkwill42 lunkwill42 lunkwill42 approved these changes

@hmpf hmpf Awaiting requested review from hmpf

@stveit stveit Awaiting requested review from stveit

Assignees

@johannaengland johannaengland

Labels

dependencies Pull requests that update a dependency file deprecation techdebt

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove Python 3.7 from default test matrix

2 participants

@johannaengland @lunkwill42