Merged
Conversation
lunkwill42
requested changes
Nov 23, 2022
Member
lunkwill42
left a comment
There was a problem hiding this comment.
This looks a-ok for now. Only nitpick is a tiny typo.
Also, please rebase to newest master to avoid the ugliness that is a failing CI pipeline (even though it's not related to this PR) on the commit this PR was based on...
Co-authored-by: Morten Brekkevold <morten.brekkevold@sikt.no>
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #2506 +/- ##
==========================================
+ Coverage 53.02% 53.31% +0.29%
==========================================
Files 554 554
Lines 40292 40315 +23
==========================================
+ Hits 21363 21494 +131
+ Misses 18929 18821 -108
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lunkwill42
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2424