Support REMOTE_USER header for web authentication#2007
Merged
lunkwill42 merged 16 commits intoUninett:masterfrom Oct 29, 2019
Merged
Support REMOTE_USER header for web authentication#2007lunkwill42 merged 16 commits intoUninett:masterfrom
lunkwill42 merged 16 commits intoUninett:masterfrom
Conversation
Closed
lunkwill42
requested changes
Oct 29, 2019
Member
lunkwill42
left a comment
There was a problem hiding this comment.
Looks mostly good by now, but there are still issues with missing documentation and a broken navuser subcommand.
There's also my usual nitpick concerning my preferred convention of the "the Stepdown rule" in NAV code. Re: "Clean code" by Robert C. Martin (Uncle Bob), a highly recommended book. Here's the relevant excerpt:
However, since you're off on a workshop these two days preceding the release, I'm going to take a stab at fixing some of these issues myself.
Because: - The so-called `default` workaround isn't a workaround at all, so it should rather have the name `none` in the config to explicitly signal that.
e58d701 to
16f70ac
Compare
lunkwill42
approved these changes
Oct 29, 2019
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1774