Skip to content

Show net ident for vlans in the portadmin vlan dropdown box#1955

Merged
lunkwill42 merged 2 commits intoUninett:4.9.xfrom
sigmunau:1934-portadmin-vlan-descriptions
May 23, 2019
Merged

Show net ident for vlans in the portadmin vlan dropdown box#1955
lunkwill42 merged 2 commits intoUninett:4.9.xfrom
sigmunau:1934-portadmin-vlan-descriptions

Conversation

@sigmunau
Copy link
Copy Markdown
Contributor

@sigmunau sigmunau commented May 22, 2019

Fixes #1935

@sigmunau sigmunau requested a review from lunkwill42 May 22, 2019 11:06
sigmunau added 2 commits May 23, 2019 11:44
When filtering objects through reverse through a foreignkey you can
get multiple identical results, this works badly with .get() which
throws a MultipleObjectsReturned exception. Resolve this by using
.distinct()
@sigmunau sigmunau force-pushed the 1934-portadmin-vlan-descriptions branch from 3d14007 to dd9c561 Compare May 23, 2019 09:44
@sigmunau sigmunau changed the title 1934 portadmin vlan descriptions Show net ident for vlans in the portadmin vlan dropdown box May 23, 2019
@lunkwill42 lunkwill42 added this to the 4.9.6 milestone May 23, 2019
Copy link
Copy Markdown
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lunkwill42 lunkwill42 merged commit 8fb3f4d into Uninett:4.9.x May 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants