Skip to content

Collapsed multiselects in status tool filters#3797

Merged
Simrayz merged 1 commit into5.17.xfrom
fix/collapsed-muliselects-in-status-tool-filters
Feb 20, 2026
Merged

Collapsed multiselects in status tool filters#3797
Simrayz merged 1 commit into5.17.xfrom
fix/collapsed-muliselects-in-status-tool-filters

Conversation

@Simrayz
Copy link
Copy Markdown
Contributor

@Simrayz Simrayz commented Feb 19, 2026

Scope and purpose

After upgrading jQuery in #3730 and select2 compatibility in #3768, the multiselects in the Status tool filters are collapsed. This PR fixes it by adding explicit width, and a re-usable Select2 widget. We might want to move this and re-use it in other tools.

Screenshots

Before After
image image

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with ruff, easiest by using pre-commit
  • Wrote the commit message so that the first line continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • Based this pull request on the correct upstream branch: For a patch/bugfix affecting the latest stable version, it should be based on that version's branch (<major>.<minor>.x). For a new feature or other additions, it should be based on master.
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done
  • If it's not obvious from a linked issue, described how to interact with NAV in order for a reviewer to observe the effects of this change first-hand (commands, URLs, UI interactions)
  • If this results in changes in the UI: Added screenshots of the before and after
  • If this adds a new Python source code file: Added the boilerplate header to that file

@Simrayz Simrayz requested a review from a team February 19, 2026 11:05
@Simrayz Simrayz self-assigned this Feb 19, 2026
@Simrayz Simrayz changed the base branch from master to 5.17.x February 19, 2026 11:05
@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 19, 2026

Test results

    20 files      20 suites   25m 22s ⏱️
 2 869 tests  2 869 ✅ 0 💤 0 ❌
16 386 runs  16 386 ✅ 0 💤 0 ❌

Results for commit 8460c38.

♻️ This comment has been updated with latest results.

@codecov
Copy link
Copy Markdown

codecov bot commented Feb 19, 2026

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 63.37%. Comparing base (6ca29f5) to head (8460c38).
⚠️ Report is 11 commits behind head on 5.17.x.

Files with missing lines Patch % Lines
python/nav/web/status2/forms.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           5.17.x    #3797   +/-   ##
=======================================
  Coverage   63.36%   63.37%           
=======================================
  Files         619      619           
  Lines       45875    45871    -4     
  Branches       43       43           
=======================================
+ Hits        29070    29071    +1     
+ Misses      16795    16790    -5     
  Partials       10       10           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lunkwill42
lunkwill42 previously approved these changes Feb 19, 2026
@Simrayz Simrayz force-pushed the fix/collapsed-muliselects-in-status-tool-filters branch from c7e9efb to 8460c38 Compare February 19, 2026 12:46
@sonarqubecloud
Copy link
Copy Markdown

@Simrayz Simrayz merged commit 31b94d8 into 5.17.x Feb 20, 2026
19 checks passed
@Simrayz Simrayz deleted the fix/collapsed-muliselects-in-status-tool-filters branch February 20, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants