Fix subnet selection bug in subnet allocator#3692
Merged
Conversation
|
Test results 27 files 27 suites 44m 53s ⏱️ Results for commit 8b5c217. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3692 +/- ##
==========================================
+ Coverage 63.01% 63.06% +0.04%
==========================================
Files 612 612
Lines 45228 45237 +9
Branches 43 43
==========================================
+ Hits 28502 28529 +27
+ Misses 16716 16698 -18
Partials 10 10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
aleksfl
approved these changes
Dec 15, 2025
Contributor
aleksfl
left a comment
There was a problem hiding this comment.
Looks good, slight confusion is mitigated by clear comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Scope and purpose
When upgrading select2, I discovered that the subnet allocator does not work (in master). Clicking on a subnet does not open the subpanel, but throws the following error in the console:
The bug is due to an incompatiblity with Marionette 2.x, which requires jQuery 2.x to work as intended. However, this PR adds a workaround which adds some manual jQuery to bypass the rendering issues.
Further follow-up work should be done to either upgrade or replace Backbone Marionette with something else, and is described in #3691.
This PR fixes the issue, and subnet allocation should work again.
Contributor Checklist
Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to NAV can be found in the
Hacker's guide to NAV.
<major>.<minor>.x). For a new feature or other additions, it should be based onmaster.